Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add menu to dashboard nav #9844

Merged

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Jun 12, 2024

Fix #9830

Loom demo: https://www.loom.com/share/ba5521f4b6464fd8bb5f6331ec5eab2e

Screenshot 2024-06-12 at 19 01 51

To test

  • Click on "Settings & Members" and see the menu pops open, looking like the designs
  • On mobile, the menu doesn't open. It just takes you to the organization settings page

@nickoferrall nickoferrall linked an issue Jun 12, 2024 that may be closed by this pull request
1 task
@nickoferrall nickoferrall changed the title Feat/9830/add menu on hover feat: add menu to dashboard nav Jun 12, 2024
Copy link
Member

@ackernaut ackernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I like the onClick menu behavior for desktop, and the direct routing on mobile! Just one detail to look at for me. Note I didn’t look super closely at all code patterns but did go over once, seems straightforward.

packages/client/components/DashNavList/DashNavMenu.tsx Outdated Show resolved Hide resolved
@nickoferrall nickoferrall merged commit a389433 into feat/9814/admin-dash-mobile-styles Jun 14, 2024
4 of 5 checks passed
@nickoferrall nickoferrall deleted the feat/9830/add-menu-on-hover branch June 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Nav: add org menu
2 participants